Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of the generic attribute to provide better typing #282

Closed
filipsobol opened this issue Jun 26, 2024 · 0 comments · Fixed by #281
Closed

Make use of the generic attribute to provide better typing #282

filipsobol opened this issue Jun 26, 2024 · 0 comments · Fixed by #281
Milestone
iteration 76

Comments

@filipsobol
Copy link
Member

We should consider using the generic attribute introduced in Vue 3.3 to provide better typings for component events.

Currently, the type of editor passed to the editor prop is ignored and all events (@ready, @focus, @blur, @input) use the generic Editor type, which is inaccurate.
@filipsobol filipsobol mentioned this issue Jun 26, 2024
Merged
filipsobol added a commit that referenced this issue Jul 11, 2024
@filipsobol
Merge pull request #281 from ckeditor/migrate-to-esm
c82a004 
Fix: Use type of the passed `editor` prop rather than generic `Editor` type. Closes #282.

Internal: Migrate from webpack and Karma to Vite and Vitest. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to ESM. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to Composition API. Closes #172.

MINOR BREAKING CHANGE: Bump required version to Vue 3.4+. See #282.

MINOR BREAKING CHANGE: Export the component as `Ckeditor` instead of `default.component`. Closes #284.

MINOR BREAKING CHANGE: Remove argument from the `destroy` event, as it was always `null`. Closes #283.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iteration 76
Development

Successfully merging a pull request may close this issue.

Migrate to ESM and Composition API ckeditor/ckeditor5-vue
2 participants
@filipsobol @CKEditorBot