-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ESM and Composition API #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo app seems to work fine 🎉
Pull Request Test Coverage Report for Build 5f570a5b-731d-4764-a4c4-edb6b30c34c5Details
💛 - Coveralls |
Please rewrite the proposed commit message to match https://ckeditor.com/docs/ckeditor5/latest/framework/contributing/git-commit-message-convention.html#convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Suggested merge commit message (convention)
Fix: Use type of the passed
editor
prop rather than genericEditor
type. Closes #282.Internal: Migrate from webpack and Karma to Vite and Vitest. See ckeditor/ckeditor5#16616.
MINOR BREAKING CHANGE: Migrate to ESM. See ckeditor/ckeditor5#16616.
MINOR BREAKING CHANGE: Migrate to Composition API. Closes #172.
MINOR BREAKING CHANGE: Bump required version to Vue 3.4+. See #282.
MINOR BREAKING CHANGE: Export the component as
Ckeditor
instead ofdefault.component
. Closes #284.MINOR BREAKING CHANGE: Remove argument from the
destroy
event, as it was alwaysnull
. Closes #283.Additional information
Closes #274.