Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESM and Composition API #281

Merged
merged 24 commits into from
Jul 11, 2024
Merged

Migrate to ESM and Composition API #281

merged 24 commits into from
Jul 11, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jun 26, 2024

Suggested merge commit message (convention)

Fix: Use type of the passed editor prop rather than generic Editor type. Closes #282.

Internal: Migrate from webpack and Karma to Vite and Vitest. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to ESM. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to Composition API. Closes #172.

MINOR BREAKING CHANGE: Bump required version to Vue 3.4+. See #282.

MINOR BREAKING CHANGE: Export the component as Ckeditor instead of default.component. Closes #284.

MINOR BREAKING CHANGE: Remove argument from the destroy event, as it was always null. Closes #283.


Additional information

Closes #274.

@pomek pomek requested a review from psmyrek June 26, 2024 11:51
src/ckeditor.vue Outdated Show resolved Hide resolved
@filipsobol filipsobol requested a review from pomek June 26, 2024 12:09
vite.config.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo app seems to work fine 🎉

src/demo/App.vue Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/ckeditor.vue Show resolved Hide resolved
src/ckeditor.vue Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
scripts/bump-year.js Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 5f570a5b-731d-4764-a4c4-edb6b30c34c5

Details

  • 56 of 56 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9751cd6f-93e0-4d44-903b-facc911287d0: 0.0%
Covered Lines: 57
Relevant Lines: 57

💛 - Coveralls

@ckeditor ckeditor deleted a comment from coveralls Jul 10, 2024
@filipsobol filipsobol requested a review from psmyrek July 10, 2024 10:03
@pomek
Copy link
Member

pomek commented Jul 10, 2024

Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@filipsobol filipsobol merged commit c82a004 into master Jul 11, 2024
3 checks passed
@filipsobol filipsobol deleted the migrate-to-esm branch July 11, 2024 10:09
basil added a commit to neanes/neanes that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants