Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the editor with multiple roots example and guide #1599

Closed
oleq opened this issue Mar 6, 2019 · 5 comments
Closed

Improvements to the editor with multiple roots example and guide #1599

oleq opened this issue Mar 6, 2019 · 5 comments
Assignees
Labels
type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@oleq
Copy link
Member

oleq commented Mar 6, 2019

A follow–up of

cc @pjasiun @f1ames

As for #1586 (comment)

If you want to change it, that's fine, but TBH I like it this way. It stresses the fact that this is a single editor.

The user does not care what's underneath. They navigate and fill the text in a form and the expect things to behave like a form. They focus one field at a time and they expect just a single field to be visually focused.

Besides, this way it's very hard to tell which editable (form field) is focused (Where's my caret? Am I typing the email address or the message yet?).

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Mar 6, 2019
@oleq oleq added this to the iteration 23 milestone Mar 6, 2019
@oleq oleq self-assigned this Mar 6, 2019
@pjasiun
Copy link

pjasiun commented Mar 6, 2019

It is fine for me to focus one element. But to clarify what I meant:

The user does not care what's underneath.

I believe that there was a reason why it was created as a single multi-root editor, not by multiple separated editor. And I believe that the reason was to provide the single-editor experience. This is why I suggest that the editor should act like this - like a single editor.

Besides, this way it's very hard to tell which editable (form field) is focused (Where's my caret? Am I typing the email address or the message yet?).

That's a good point, in fact.

@oleq
Copy link
Member Author

oleq commented Mar 6, 2019

Anyway, check out screencasts in #1600 (comment).

@oleq
Copy link
Member Author

oleq commented Mar 6, 2019

I'd give the toolbar some space because now it looks like it belongs to the first root only
image

WDYT?

@Reinmar
Copy link
Member

Reinmar commented Mar 7, 2019

Isn't this ticket a DUP of #1596 (or vice versa)?

@oleq
Copy link
Member Author

oleq commented Mar 12, 2019

This one is a DUP but since there's a lot going on here already, I marked the other one as DUP.

jodator added a commit to ckeditor/ckeditor5-utils that referenced this issue Mar 26, 2019
Feature: Made `FocusTracker#focusedElement` observable to bring support for multi-root editors (see ckeditor/ckeditor5#1599).
jodator added a commit that referenced this issue Mar 26, 2019
Docs: Improvements to the editor with multiple roots example and guide. Closes #1599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants