Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t/1599: Improvements to the editor with multiple roots example and guide #1600

Merged
merged 4 commits into from
Mar 26, 2019
Merged

t/1599: Improvements to the editor with multiple roots example and guide #1600

merged 4 commits into from
Mar 26, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 6, 2019 •
edited
Loading

Suggested merge commit message (convention)

Docs: Improvements to the editor with multiple roots example and guide. Closes #1599.

Requires ckeditor/ckeditor5-utils#276.

@oleq
Copy link
Member Author

oleq commented Mar 6, 2019

Focus management

Before

kapture 2019-03-06 at 17 02 29

After

kapture 2019-03-06 at 17 00 43

@oleq oleq mentioned this pull request Mar 6, 2019
Closed
@oleq
Copy link
Member Author

oleq commented Mar 6, 2019

Better placeholders:

image

@oleq oleq marked this pull request as ready for review March 7, 2019 10:23
@oleq oleq requested a review from jodator March 7, 2019 14:10
jodator
jodator approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jodator jodator merged commit 806ff79 into master Mar 26, 2019
@jodator jodator deleted the t/1599 branch March 26, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleq @jodator