Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OT using engine.treeModel.Range#getTransformedByMove #3695

Closed
scofalik opened this issue May 4, 2016 · 1 comment
Closed

Refactor OT using engine.treeModel.Range#getTransformedByMove #3695

scofalik opened this issue May 4, 2016 · 1 comment
Labels
package:engine resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

scofalik commented May 4, 2016

After ckeditor/ckeditor5-engine#392 is merged, we should refactor operational transformation algoirthms so they use the newly introduced method. Right now we have a bit of code duplication.
@scofalik scofalik self-assigned this May 4, 2016
@scofalik scofalik removed their assignment Jul 7, 2017
@scofalik
Copy link
Contributor Author

I don't remember where was the duplication but OT code got refactored a bit and AFAICS now, the code is alright, so I am closing this issue.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
arkflpc added a commit that referenced this issue Jun 25, 2024
@arkflpc
Merge pull request #16473 from ckeditor/ck/3695-extend-configuration-…
6c0145a 
…in-ckbox

Feature (ckbox): Added more configuration options passed down to the CKBox. Closes #3695.
@CKEditorBot CKEditorBot mentioned this issue Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scofalik @mlewand