Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resized image flickers/flashes on first resize when no width is assigned #5189

Closed
mlewand opened this issue Aug 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-widget#112 or ckeditor/ckeditor5-image#334
Closed

Resized image flickers/flashes on first resize when no width is assigned #5189

mlewand opened this issue Aug 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-widget#112 or ckeditor/ckeditor5-image#334
Assignees
@mlewand
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 19, 2019 •
edited
Loading

Is this a bug report or feature request?

🐞 Bug report

💻 Version of CKEditor

CKEditor v5 @ latest master

📋 Steps to reproduce

  1. Open image resize manual test.
  2. Focus the image under "Image (width: not set)" section in the first editor.
  3. Turn it to a side image using image toolbar.
  4. Make sure that the image is smaller than editor viewport.
  5. Start to resize.

✅ Expected result

Image is limited to the size pointed by the cursor.

❎ Actual result

Image flashes for a very brief time and then is resized to a proper geometry.

resizer-initial-flicker
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@mlewand mlewand modified the milestones: iteration 27, iteration 28 Oct 16, 2019
@mlewand mlewand mentioned this issue Oct 18, 2019
Closed
@mlewand mlewand mentioned this issue Oct 30, 2019
Closed
This was referenced Nov 15, 2019
Merged
Merged
@Reinmar Reinmar modified the milestones: iteration 28, iteration 29 Nov 25, 2019
@mlewand mlewand mentioned this issue Dec 5, 2019
Closed
Reinmar added a commit to ckeditor/ckeditor5-widget that referenced this issue Jan 3, 2020
@Reinmar
Merge pull request #112 from ckeditor/i/5189
d6a5c93 
Fix: Fixed image resize behavior upon short clicking a handle without dragging. Image will no longer became full width, nor will it briefly flash an unexpected size. Closes ckeditor/ckeditor5#5189. Closes ckeditor/ckeditor5#5195.

MINOR BREAKING CHANGE: Resizer options object now also takes an editor instance.
Reinmar added a commit to ckeditor/ckeditor5-image that referenced this issue Jan 3, 2020
@Reinmar
Merge pull request #334 from ckeditor/i/5189
9148013 
Fix: Fixed image resize behavior upon short clicking a handle without dragging. Image will no longer became full width, nor will it briefly flash an unexpected size. Closes ckeditor/ckeditor5#5189 and closes ckeditor/ckeditor5#5195.

MINOR BREAKING CHANGE: Resizer options object now also takes an editor instance.

MINOR BREAKING CHANGE: Removed the `downcastWriter` property from the [`ResizerOptions` interface](https://ckeditor.com/docs/ckeditor5/latest/api/module_widget_widgetresize-ResizerOptions.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
2 participants
@Reinmar @mlewand