Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image changes size after clicking on resize handler #5195

Closed
Mgsy opened this issue Aug 21, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-widget#112 or ckeditor/ckeditor5-image#334
Closed

Image changes size after clicking on resize handler #5195

Mgsy opened this issue Aug 21, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-widget#112 or ckeditor/ckeditor5-image#334
Assignees
@mlewand
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@Mgsy
Copy link
Member

Mgsy commented Aug 21, 2019

After clicking on a image resize handler, the image changes its size.

resize

If you'd like to see this fixed sooner, add 👍 to this post.
@mlewand
Copy link
Contributor

mlewand commented Sep 5, 2019

Actually giving it more thinking, I'm thinking it's a more severe issue as on touchpads some users might tend to double tap the touchbar in order to start dragging. This issue will impact such case.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@oleq
Copy link
Member

oleq commented Oct 18, 2019

Bumped again into this one. It's pretty annoying I must admit. Is it hard to fix?

@mlewand
Copy link
Contributor

mlewand commented Oct 18, 2019

Shouldn't be. There's a slight chance that it's related to #5189 so hopefully we could fix both at once.

This was referenced Nov 15, 2019
Merged
Merged
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 28, iteration 29 Nov 21, 2019
@mlewand mlewand self-assigned this Dec 11, 2019
Reinmar added a commit to ckeditor/ckeditor5-widget that referenced this issue Jan 3, 2020
@Reinmar
Merge pull request #112 from ckeditor/i/5189
d6a5c93 
Fix: Fixed image resize behavior upon short clicking a handle without dragging. Image will no longer became full width, nor will it briefly flash an unexpected size. Closes ckeditor/ckeditor5#5189. Closes ckeditor/ckeditor5#5195.

MINOR BREAKING CHANGE: Resizer options object now also takes an editor instance.
Reinmar added a commit to ckeditor/ckeditor5-image that referenced this issue Jan 3, 2020
@Reinmar
Merge pull request #334 from ckeditor/i/5189
9148013 
Fix: Fixed image resize behavior upon short clicking a handle without dragging. Image will no longer became full width, nor will it briefly flash an unexpected size. Closes ckeditor/ckeditor5#5189 and closes ckeditor/ckeditor5#5195.

MINOR BREAKING CHANGE: Resizer options object now also takes an editor instance.

MINOR BREAKING CHANGE: Removed the `downcastWriter` property from the [`ResizerOptions` interface](https://ckeditor.com/docs/ckeditor5/latest/api/module_widget_widgetresize-ResizerOptions.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
4 participants
@Reinmar @oleq @mlewand @Mgsy