Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CC in 3 packages #5848

Closed
2 of 3 tasks
Reinmar opened this issue Nov 27, 2019 · 7 comments
Closed
2 of 3 tasks

Fix CC in 3 packages #5848

Reinmar opened this issue Nov 27, 2019 · 7 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 27, 2019

Code coverage dropped there: https://coveralls.io/builds/27275642/source?filename=packages%2Fckeditor5-utils%2Fsrc%2Fversion.js

Packages

  • utils
  • watchdog
  • upload
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". status:confirmed labels Nov 27, 2019
@Reinmar Reinmar added this to the iteration 28 milestone Nov 27, 2019
@pomek
Copy link
Member

pomek commented Nov 28, 2019

@Reinmar Reinmar changed the title Fix CC in ckeditor5-utils version.js Fix CC in 3 packages Nov 28, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Nov 28, 2019

Thanks, I updated the title to cover all 3 places.

@oleq
Copy link
Member

oleq commented Nov 29, 2019

2 branches + 1 follow-up and it's ready for review.

mlewand added a commit to ckeditor/ckeditor5-watchdog that referenced this issue Dec 2, 2019
mlewand added a commit to ckeditor/ckeditor5-utils that referenced this issue Dec 2, 2019
@mlewand
Copy link
Contributor

mlewand commented Dec 2, 2019

@oleq since we won't be tackling #5875 soon, can you add a PR with instanbul ignore directive for the upload package?

@oleq
Copy link
Member

oleq commented Dec 2, 2019

Are you sure this is the right thing to do? This is a real case where we don't have coverage because we don't understand how the code works. This is a good reminder that we need to address this issue.

@mlewand
Copy link
Contributor

mlewand commented Dec 3, 2019

I hear you, that being said, I don't think we have the time to investigate it properly now. So marking it with an ignore and giving a reference to #5875 sounds like a sane idea. I'm not sure whether #5875 is severe enough to put it in the next iteration or should it stay in our todo list. @Reinmar what's your take on this?

@oleq
Copy link
Member

oleq commented Dec 3, 2019

I created a follow-up in #5892 so we can close this issue and get back to the problem later on.

@oleq oleq closed this as completed Dec 3, 2019
@oleq oleq reopened this Dec 3, 2019
@oleq oleq closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants