-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CC in 3 packages #5848
Comments
CC is below 100% also in other packages: |
Thanks, I updated the title to cover all 3 places. |
2 branches + 1 follow-up and it's ready for review. |
Are you sure this is the right thing to do? This is a real case where we don't have coverage because we don't understand how the code works. This is a good reminder that we need to address this issue. |
I hear you, that being said, I don't think we have the time to investigate it properly now. So marking it with an ignore and giving a reference to #5875 sounds like a sane idea. I'm not sure whether #5875 is severe enough to put it in the next iteration or should it stay in our todo list. @Reinmar what's your take on this? |
I created a follow-up in #5892 so we can close this issue and get back to the problem later on. |
Code coverage dropped there: https://coveralls.io/builds/27275642/source?filename=packages%2Fckeditor5-utils%2Fsrc%2Fversion.js
Packages
The text was updated successfully, but these errors were encountered: