-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the CC in the Upload package #5892
Improve the CC in the Upload package #5892
Comments
OK, I spent a bit of time on this code and I'm 99% sure that this state is impossible to be reached. Whenever the file reader is aborted, the promise is rejected so we end up in In the past, you could do I'll remove this condition. |
Tests: Removed a condition which is not reachable anymore. Closes ckeditor/ckeditor5#5892.
This appeared on CI after we merged ckeditor/ckeditor5-upload#106 😂. So it seems that I was wrong. |
It's this test:
|
This is odd because CI passed for the PR... And I ran it locally and it is clean
|
Fix: Restored a condition handling an edge case in upload vs abort promise chains. Closes ckeditor/ckeditor5#5892.
Fix: Restored a condition handling an edge case in upload vs abort promise chains. Closes #5892.
The CC is not 100% and we should figure out what to do about it. This issue is strictly about CC but more details about some general problems in the package can be found in #5875.
A follow-up of #5848.
The text was updated successfully, but these errors were encountered: