This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Update default value of reserved_concurrent_executions to -1 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, please, this made for a really weird deploy day for us... |
|
Hi, sorry I didn't see this sooner. I think we should add an AWS provider restriction for |
|
Just looking into this myself and I don't think you can really pin a provider version in a module without also specifying other fields like region, credentials, etc. I'm currently testing how this works with different versions and will report back. |
|
How the AWS provider works:
So setting it to |
|
This is in |
asavoy
added a commit
to mathspace/terraform-aws-lambda
that referenced
this pull request
Aug 17, 2020
gokuldaemon
pushed a commit
to Daemon-Solutions/tf-aws-elasticsearch-curator
that referenced
this pull request
Oct 22, 2020
As per claranet/terraform-aws-lambda#39 if a recent version of the AWS provider is used and that fix is not in place then the result is that the Lambda function is disabled. Upgrading the Lambda module makes this module work with recent AWS provider versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hashicorp/terraform-provider-aws#3806 has been merged into the Terraform AWS Provider 2.0, the current default value of this module will effectively mean no Lambda invocations will be handled. By setting the default value to -1 instead of 0, we return to the original unrestricted value.