This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Add AWS Provider Version Constraint #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS Provider modifies the way Lambda Concurrency is handled so that: -1 == unreserved concurrency 0 == zero concurrency (do not run) >1 == reserved concurrency limits previous provider versions had used 0 to indicate unreserved concurrency This change adds the AWS provider version constraing `>= 2.0.0` to ensure the provider behaves as expected for the module
|
Unfortunately, we can't do this because it also overrides provider configuration. This is explained more in hashicorp/terraform#16835 and will be fixed in Terraform 0.12. |
|
For context, the problem that @claranet-barney is trying to fix is related to #39 which changed the default concurrency from 0 to -1. This technically works with all AWS provider versions (the deployed Lambda functions work fine) but with AWS provider versions before 2.0.0 Terraform will incorrectly read the -1 as 0 and want to change it back to -1 again. |
|
Thanks @raymondbutcher that makes sense, i'll close this one 👍 |
mbklein
pushed a commit
to nulib/terraform-aws-lambda
that referenced
this pull request
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Provider modifies the way Lambda Concurrency is handled so that:
-1 == unreserved concurrency
0 == zero concurrency (do not run)
previous provider versions had used 0 to indicate unreserved
concurrency
This change adds the AWS provider version constraing
>= 2.0.0toensure the provider behaves as expected for the module