Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript, Svelte, and related packages to latest #345

Closed
chrispcampbell opened this issue Aug 31, 2023 · 0 comments · Fixed by #346
Closed

Upgrade TypeScript, Svelte, and related packages to latest #345

chrispcampbell opened this issue Aug 31, 2023 · 0 comments · Fixed by #346
Assignees
Labels
dependencies Pull requests that update a dependency file improvement

Comments

@chrispcampbell
Copy link
Contributor

chrispcampbell commented Aug 31, 2023

After upgrading to VS Code 1.77.3 a few months back (which included TypeScript 5 support), our tsconfig.json files are now being highlighted in red due to some tsconfig properties that were deprecated in TS 5.0.

The new replacement for importsNotUsedAsValues is verbatimModuleSyntax:
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#verbatimmodulesyntax
microsoft/TypeScript#52203
https://typescript-eslint.io/rules/consistent-type-imports/

We should upgrade to the latest TypeScript and update the tsconfig.json files (and our ESLint settings) to make this problem go away.

Some additional notes from when I went through a similar upgrade for En-ROADS a couple months ago:

This was supposed to be a simple change to some tsconfig files, but as is typical for a TypeScript upgrade, it prompted upgrades for other related packages. Our older version of svelte-check is not compatible with TS 5, so I upgraded that, but the latest svelte-check requires a newer version of svelte, so I upgraded that as well. Also had to upgrade to the latest version of eslint and related packages.

The upgrade to svelte-check causes many new a11y warnings that I've had to silence for the time being.

I will also need to upgrade typedoc to the latest version, since the one we had pinned earlier didn't fully support TS 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement
Projects
None yet
1 participant