forked from stripe/veneur
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing substring lookup, added tests (stripe#1012)
When metrics are going through the globalization pipeline metrics from veneur local will have tags added to them by the `add_tags` functionality when these same metrics arrive at the globalization pipeline if veneur global has its own `add_tags` specified that overlap with those from veneur local we would end up with duplicate tags. See the original fix [here](stripe#1009). As to why this PR: when accessing a substring of ft where `len(k)` is longer than `ft` itself we'll receive an out of bounds error, I was operating under the assumption they'd behave a lot like python strings where this behavior is valid: ``` Python 3.9.11 (main, Sep 13 2022, 16:05:34) [Clang 13.1.6 (clang-1316.0.21.2.5)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> foo = "test" >>> foo[0:20] 'test' ```
- Loading branch information
1 parent
0f8f107
commit 2cc4ce6
Showing
2 changed files
with
55 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters