Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance docs per CE PR 1226 #565

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Governance docs per CE PR 1226 #565

merged 1 commit into from
Sep 28, 2023

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Sep 21, 2023

Governance docs per CE PR 1226
2085b7f 
Signed-off-by: Doug Davis <dug@microsoft.com>
lholmquist
lholmquist reviewed Sep 22, 2023
View reviewed changes
MAINTAINERS.md
- [Daniel Bevenius](https://github.com/danbev)
- [Lucas Holmquist](https://github.com/lholmquist)
- [Fabio Jose](https://github.com/fabiojose)
- [Helio Frota](https://github.com/helio-frota)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure myself and lance would be the only two as active maintainers at this point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going by what i see here: https://github.com/orgs/cloudevents/teams/sdk-javascript-maintainers
If you'd like you could start a vote to reduce it down to just you two per: https://github.com/cloudevents/spec/blob/main/docs/SDK-GOVERNANCE.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@duglin
Copy link
Contributor Author

duglin commented Sep 28, 2023

ping @lance @danbev @lholmquist @fabiojose @helio-frota
We can always do another PR after the maintainer list has been pruned.

lance
lance approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Agree the maintainers list needs pruning. That can come after this.

@helio-frota
Copy link
Contributor

Agree the maintainers list needs pruning. That can come after this.

+1

and also agree with @lholmquist

@lance lance merged commit 16d0c0f into cloudevents:main Sep 28, 2023
6 checks passed
@duglin duglin deleted the governance branch September 28, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duglin @helio-frota @lance @lholmquist