Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed alignment of SDK governance files #1226

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

duglin
Copy link
Collaborator

@duglin duglin commented Sep 14, 2023

To address the governance review: cncf/tag-contributor-strategy#509

@duglin
Copy link
Collaborator Author

duglin commented Sep 14, 2023

@cloudevents/sdk-maintainers please review this. On today's call we agreed that we should be consistent with some of the governance aspects of the SDK and as part of that we should use the same names for common files. Please see if the proposed names are ok. If not, please speak up and propose an alternative.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight tweak, but fundamentally I absolutely agree.

## SDK Repository Requirements

Each SDK must include the following:
- a pointer to it's github repo from the CloudEvents [README.md](README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's => its

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG I can't type that correctly! Seriously, I do know it!

file
- a README.md file with at least the following information:
- a description of the SDK
- a "Community" section with information about how to participate and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that "how to participate" is required here when CONTRIBUTING.md is also required... although it would be good to link to that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I tweaked it - see if it's better now

Signed-off-by: Doug Davis <dug@microsoft.com>
@duglin
Copy link
Collaborator Author

duglin commented Sep 14, 2023

@cloudevents/sdk-maintainers while I have your attention... please see this poll in the ce-sdk slack: https://cloud-native.slack.com/archives/CCXF3CBL1/p1694717251192769

jskeet added a commit to jskeet/sdk-csharp that referenced this pull request Sep 15, 2023
Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet added a commit to jskeet/sdk-csharp that referenced this pull request Sep 15, 2023
Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet added a commit to cloudevents/sdk-csharp that referenced this pull request Sep 15, 2023
Signed-off-by: Jon Skeet <jonskeet@google.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Collaborator Author

duglin commented Sep 19, 2023

Copy link

@helio-frota helio-frota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Collaborator Author

duglin commented Sep 21, 2023

Approved on the 9/21 call

pierDipi pushed a commit to cloudevents/sdk-java that referenced this pull request Sep 28, 2023
Related to cloudevents/spec#1226

Signed-off-by: Doug Davis <dug@microsoft.com>
ericdotnet added a commit to ericdotnet/CSharp-sdk-dev that referenced this pull request May 13, 2024
Signed-off-by: Jon Skeet <jonskeet@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.