Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compatibility date and flags #1177

Merged

Conversation

sbfaulkner
Copy link
Contributor

Description

This PR adds support for the compatibility_date and compatibility_flags options when uploading a worker script.
https://developers.cloudflare.com/workers/platform/compatibility-dates/

Has your change been tested?

  • test included

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

/fyi @GustavoCaso - attempting to get Shopify#13 upstreamed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #1177 (0976726) into master (6153c1e) will decrease coverage by 0.02%.
The diff coverage is 50.22%.

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   49.40%   49.37%   -0.03%     
==========================================
  Files         127      128       +1     
  Lines       12290    12416     +126     
==========================================
+ Hits         6072     6131      +59     
- Misses       4840     4883      +43     
- Partials     1378     1402      +24     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare_experimental.go 0.00% <0.00%> (ø)
teams_rules.go 44.94% <0.00%> (-0.52%) ⬇️
utils.go 72.72% <ø> (ø)
cloudflare.go 68.37% <14.28%> (-0.34%) ⬇️
mtls_certificates.go 26.59% <26.59%> (ø)
origin_ca.go 57.26% <90.90%> (-2.09%) ⬇️
dns.go 72.72% <96.36%> (+9.00%) ⬆️
devices_managed_networks.go 41.55% <100.00%> (+9.09%) ⬆️
email_routing_destination.go 66.66% <100.00%> (+0.41%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

thanks @sbfaulkner 🍰

@jacobbednarz jacobbednarz merged commit 547c059 into cloudflare:master Jan 12, 2023
@github-actions github-actions bot added this to the v0.59.0 milestone Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.59.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sbfaulkner sbfaulkner deleted the add-support-for-compatibility-flags branch January 24, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants