Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update branch #1370

Closed
wants to merge 20 commits into from
Closed

Update branch #1370

wants to merge 20 commits into from

Conversation

brandonjfordham
Copy link

Description

Has your change been tested?

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Cyb3r-Jak3 and others added 20 commits August 18, 2023 09:06
@Cyb3r-Jak3
Add support for pages deployment auto pagination
9684159
@Cyb3r-Jak3
Change DeletePagesDeploymentParams to be the URL parameters
075a511
@Cyb3r-Jak3
Fix linting
5112754
@Cyb3r-Jak3
Pages support max of 25 for per_page
bd136a1
@Cyb3r-Jak3
PR comments
01d74a1
@jacobbednarz
update more method signatures to match conventions
4e829b0
@Cyb3r-Jak3
Add support for providing branch name when creating a deployment
7dbcc80
@Cyb3r-Jak3
Implement ResultInfo.DoneCount() for result_info that doesn't impleme…
421b08d 
…nt total_pages
@Cyb3r-Jak3
Update pages_deployment to use the correct way to pagination.
5563861
@jacobbednarz
split usage of ID and Name
2b37729 
Pages, unfortunately, uses a friendly name for the identifier in the URL
so to be able to update the `Name` value we need a way to differentiate
the two. The way I've solved this here is that `ID` is used for
addressing the resource via the UI or a stable identifier whereas `Name`
is used for updating the value.
@dependabot
build(deps): bump golang.org/x/net from 0.11.0 to 0.12.0
3362c64 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.11.0 to 0.12.0.
- [Commits](golang/net@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
add CHANGELOG for #1328
8f5e644
Update CHANGELOG.md for #1328
040a447
@jacobbednarz
fix test assertions
08f5487
Update CHANGELOG.md for #1264
af13301
Add DCV delegation records
90a2d09
add dcv uuid to zone
42b7bcc
test
e880035
test
71e7bf4
test
3d0b4d2
@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonjfordham @Cyb3r-Jak3 @jacobbednarz