[bazel] Do not compile wd_cc_library by default #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
approved these changes
Jan 2, 2024
fhanau
changed the title
fhanau
changed the title
fhanau
force-pushed
the
felix/lib-off-by-default
branch
from
b122d93 to
100145d
Compare
mrbbot
approved these changes
Jan 29, 2024
jasnell
approved these changes
Jan 29, 2024
fhanau
force-pushed
the
felix/lib-off-by-default
branch
from
100145d to
56defad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark library targets as off-by-default. We do not ship any libraries as part of workerd releases or use them outside of bazel, so there is generally no need to build them explicitly. This allows us to not build library targets by default. Note that on macOS (and likely Windows) library targets will still be built as dependencies of other targets such as tests and workerd itself as
start_stop_libis not supported – on Linux binaries are built directly from object files so there's no need to build the library files.This reduces the size of the build output folder from 6.1GB to 5.9GB on Linux CI builds.