Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Do not compile wd_cc_library by default #1512

Merged
merged 1 commit into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build/wd_cc_library.bzl
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
"""wd_cc_library definition"""

def wd_cc_library(strip_include_prefix = "/src", **kwargs):
def wd_cc_library(strip_include_prefix = "/src", tags = ["off-by-default"], **kwargs):
"""Wrapper for cc_library that sets common attributes
"""
native.cc_library(
strip_include_prefix = strip_include_prefix,
tags = tags,
**kwargs
)
4 changes: 4 additions & 0 deletions src/workerd/tools/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ wd_cc_library(
"//src/workerd/jsg:rtti",
"@capnp-cpp//src/capnp",
],
target_compatible_with = select({
"@platforms//os:windows": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
)

api_encoder_src = "api-encoder.c++"
Expand Down
2 changes: 1 addition & 1 deletion src/workerd/util/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ wd_cc_library(
deps = [
"@capnp-cpp//src/kj"
] + select({
"@platforms//os:windows": ["@workerd-v8//:v8"],
"@platforms//os:windows": [],
"//conditions:default": ["@perfetto//:libperfetto_client_experimental"],
}),
defines = select({
Expand Down
Loading