[wrangler] Prevents uploads with both cron triggers and smart placement enabled

[shahsimpson]

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:
This PR prevents uploads that enable smart placement and include cron triggers. Cron triggers are currently unsupported with smart placement.

Author has included the following, where applicable:

• Tests
• Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

[changeset-bot]

🦋 Changeset detected

Latest commit: 609a118

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Skye-31]

Wouldn't it make more sense to do this validation in the API? If it becomes supported in future, it won't require people to update their wrangler versions

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5158640018/npm-package-wrangler-3390

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3390/npm-package-wrangler-3390

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5158640018/npm-package-wrangler-3390 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5158640018/npm-package-cloudflare-pages-shared-3390

Note that these links will no longer work once the GitHub Actions artifact expires.

[petebacondarwin]

Tidy work for someone who doesn't know the code base.
Nice one @shahsimpson.

Just a couple of NITs and one minor request about ensuring test-coverage. Otherwise LGTM.

[codecov]

Codecov Report

Merging #3390 (609a118) into main (a728876) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
+ Coverage   75.42%   75.47%   +0.05%     
==========================================
  Files         182      182              
  Lines       11063    11070       +7     
  Branches     2902     2903       +1     
==========================================
+ Hits         8344     8355      +11     
+ Misses       2719     2715       -4     

Impacted Files	Coverage Δ
packages/wrangler/src/config/validation-helpers.ts	99.01% <100.00%> (+0.02%)	⬆️
packages/wrangler/src/config/validation.ts	90.43% <100.00%> (+0.01%)	⬆️

... and 3 files with indirect coverage changes

[shahsimpson]

Wouldn't it make more sense to do this validation in the API? If it becomes supported in future, it won't require people to update their wrangler versions

Hi @Skye-31! This validation is done in the API as well. Since the calls to deploy a worker and update cron triggers go to separate endpoints, we want to allow for users that had already deployed workers with both configured (before we added that validation) to continue to deploy via Wrangler while also being pushed to update their config.

[petebacondarwin]

Love it! Nice work @shahsimpson - LGTM.