Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Allows uploads with both cron triggers and smart placement enabled #4219

Conversation

maxwellpeterson
Copy link
Member

Revert "Prevents uploads with both cron triggers and smart placement enabled (#3390)"

This reverts commit b5b46b4.

Fixes WP-591.

What this PR solves / how to test:

Lifts a temporary restriction that was put in place because of a bug with smart placement that made it incompatible with cron triggers. That bug has been fixed and users are now free to use smart placement and cron triggers together.

Associated docs issue(s)/PR(s):

  • N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@maxwellpeterson maxwellpeterson requested a review from a team as a code owner October 18, 2023 15:40
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 471aae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-wrangler-4219

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6645687983/npm-package-wrangler-4219

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-wrangler-4219 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-cloudflare-pages-shared-4219

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.14.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231016.0 3.20231016.0
workerd 1.20231016.0 1.20231016.0
workerd --version 1.20231016.0 2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #4219 (471aae5) into main (b404ab7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4219      +/-   ##
==========================================
+ Coverage   75.33%   75.36%   +0.02%     
==========================================
  Files         223      223              
  Lines       12294    12287       -7     
  Branches     3177     3176       -1     
==========================================
- Hits         9262     9260       -2     
+ Misses       3032     3027       -5     
Files Coverage Δ
packages/wrangler/src/config/validation-helpers.ts 99.00% <ø> (-0.03%) ⬇️
packages/wrangler/src/config/validation.ts 90.09% <ø> (-0.02%) ⬇️

... and 4 files with indirect coverage changes

@maxwellpeterson maxwellpeterson force-pushed the maxwellpeterson/allow-placement-and-triggers branch from 71772aa to 1fb43ac Compare October 19, 2023 22:29
Revert "Prevents uploads with both cron triggers and smart placement enabled (cloudflare#3390)"

This reverts commit b5b46b4.
@maxwellpeterson maxwellpeterson force-pushed the maxwellpeterson/allow-placement-and-triggers branch from 1fb43ac to 471aae5 Compare October 25, 2023 20:17
@penalosa penalosa merged commit 0453b44 into cloudflare:main Oct 27, 2023
20 checks passed
@kesar
Copy link

kesar commented May 14, 2024

I am getting "Placement is not supported with cron triggers" was this reverted again ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants