-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] Improve bindings support in Svelte template #5027
Conversation
🦋 Changeset detectedLatest commit: 05ee253 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-wrangler-5027 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5027/npm-package-wrangler-5027 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-wrangler-5027 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-create-cloudflare-5027 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-cloudflare-kv-asset-handler-5027 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-miniflare-5027 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-cloudflare-pages-shared-5027 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5027 +/- ##
==========================================
- Coverage 70.48% 70.47% -0.02%
==========================================
Files 297 297
Lines 15425 15425
Branches 3952 3952
==========================================
- Hits 10873 10870 -3
- Misses 4552 4555 +3 |
updated = tsconfig; | ||
} | ||
const explicitEntrypoint = (currentTypes as string[]).some((t) => | ||
t.match(/@cloudflare\/workers-types\/\d{4}-\d{2}-\d{2}/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should we also consider @cloudflare/workers-types/experimental
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
Besides the failing test and mv
What this PR solves / how to test:
platform
object withgetPlatformProxy
in dev.wrangler.toml
filebuild-cf-types
script to generate bindings types viawrangler types
.app.d.ts
to include types forctx
andcf
in addition to theenv
type described abovetsconfig.json
when adding theworkers-types
entrypoint by switching the implementation tojsonc-parser
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.