Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] Improve bindings support in Svelte template #5027

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Feb 15, 2024

What this PR solves / how to test:

  • Updates the Svelte template add a hook to populate the platform object with getPlatformProxy in dev.
  • Adds a default wrangler.toml file
  • Adds a build-cf-types script to generate bindings types via wrangler types.
  • Updates the app.d.ts to include types for ctx and cf in addition to the env type described above
  • Improves the reliability of parsing a project's tsconfig.json when adding the workers-types entrypoint by switching the implementation to jsonc-parser

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team as a code owner February 15, 2024 22:23
Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 05ee253

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jculvey jculvey changed the title C3 Improve bindings support in Svelte template [C3] Improve bindings support in Svelte template Feb 15, 2024
Copy link
Contributor

github-actions bot commented Feb 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-wrangler-5027

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5027/npm-package-wrangler-5027

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-wrangler-5027 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-create-cloudflare-5027 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-cloudflare-kv-asset-handler-5027
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-miniflare-5027
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7924978234/npm-package-cloudflare-pages-shared-5027

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.2
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e74c74) 70.48% compared to head (05ee253) 70.47%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5027      +/-   ##
==========================================
- Coverage   70.48%   70.47%   -0.02%     
==========================================
  Files         297      297              
  Lines       15425    15425              
  Branches     3952     3952              
==========================================
- Hits        10873    10870       -3     
- Misses       4552     4555       +3     

see 1 file with indirect coverage changes

updated = tsconfig;
}
const explicitEntrypoint = (currentTypes as string[]).some((t) =>
t.match(/@cloudflare\/workers-types\/\d{4}-\d{2}-\d{2}/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we also consider @cloudflare/workers-types/experimental?

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

Besides the failing test and mv

@jculvey jculvey merged commit a751489 into main Feb 16, 2024
22 checks passed
@jculvey jculvey deleted the c3-svelte-bindings-update branch February 16, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants