-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] Use new vite based Remix template #5080
Conversation
🦋 Changeset detectedLatest commit: c9f1634 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-wrangler-5080 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5080/npm-package-wrangler-5080 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-wrangler-5080 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-create-cloudflare-5080 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-kv-asset-handler-5080 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-miniflare-5080 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-pages-shared-5080 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-vitest-pool-workers-5080 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5080 +/- ##
==========================================
+ Coverage 70.33% 70.40% +0.06%
==========================================
Files 298 298
Lines 15515 15515
Branches 3987 3987
==========================================
+ Hits 10913 10923 +10
+ Misses 4602 4592 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 😄
Except the two minor things I mentioned, please address them before merging 🙂 🙏
.changeset/six-pans-marry.md
Outdated
|
||
feature: Use new `vite-cloudflare` template in Remix projects. | ||
|
||
Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getBindingsProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getBindingsProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template. | |
Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getPlatformProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template. |
}, | ||
}); | ||
|
||
s.stop(`${brandColor("updated")} \`${typeDefsPath}\``); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adopts the new official
vite-cloudflare
template from Remix in projects created by C3. This gives better out of the box support for bindings viagetPlatformProxy
.See also:
Author has addressed the following:
Tests
Changeset (Changeset guidelines)
Associated docs
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.