Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] Use new vite based Remix template #5080

Merged
merged 8 commits into from
Feb 26, 2024
Merged

[C3] Use new vite based Remix template #5080

merged 8 commits into from
Feb 26, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Feb 23, 2024

Adopts the new official vite-cloudflare template from Remix in projects created by C3. This gives better out of the box support for bindings via getPlatformProxy.

See also:

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team as a code owner February 23, 2024 20:34
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: c9f1634

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-wrangler-5080

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5080/npm-package-wrangler-5080

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-wrangler-5080 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-create-cloudflare-5080 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-kv-asset-handler-5080
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-miniflare-5080
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-pages-shared-5080
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8050819799/npm-package-cloudflare-vitest-pool-workers-5080

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.29.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240208.0
workerd 1.20240208.0 1.20240208.0
workerd --version 1.20240208.0 2024-02-08

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (cab7e1c) to head (c9f1634).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5080      +/-   ##
==========================================
+ Coverage   70.33%   70.40%   +0.06%     
==========================================
  Files         298      298              
  Lines       15515    15515              
  Branches     3987     3987              
==========================================
+ Hits        10913    10923      +10     
+ Misses       4602     4592      -10     

see 7 files with indirect coverage changes

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 😄

Except the two minor things I mentioned, please address them before merging 🙂 🙏


feature: Use new `vite-cloudflare` template in Remix projects.

Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getBindingsProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getBindingsProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template.
Remix has released a [new official Cloudflare template](https://remix.run/docs/en/main/future/vite#cloudflare-proxy) that uses `getPlatformProxy` under the hood to provide better support for bindings in dev. Remix projects created with C3 will now use this new template.

},
});

s.stop(`${brandColor("updated")} \`${typeDefsPath}\``);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this missing the dim?

Screenshot 2024-02-24 at 00 33 39

Suggested change
s.stop(`${brandColor("updated")} \`${typeDefsPath}\``);
s.stop(`${brandColor("updated")} ${dim(`\`${typeDefsPath}\``)}`);

@jculvey jculvey merged commit 2aa7913 into main Feb 26, 2024
22 checks passed
@jculvey jculvey deleted the c3-remix-new-template branch February 26, 2024 15:17
This was referenced Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants