-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new metric application_buildpack #126
Added new metric application_buildpack #126
Conversation
@adamspd just to ask one upfront question, are all those commits related to the new application_buildpack metric? If not it would be appreciated if they could spread across different PRs which would make it way easier to review them |
7230117
to
ab6ec61
Compare
Hi @benjaminguttmann-avtq, the commits were not related to a single metric but to the addition of 2 new metrics and the modification of a metric to add more information. I separated them into 3 pull requests as requested and yes, you're right, it will be easier later if we need to go back on one of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fetchAndFilterDroplets() should be added to the workers execution pool using c.worker.PushIf("droplets", c.fetchDroplets, filters.Droplets)
@adamspd Please make sure to run |
Absolutely. |
42dd55d
to
ce93f84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @adamspd
No description provided.