Cleanup droplets on kpack.Build deletion
#2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
issues/2229-delete-droplets
branch
from
9d921a0
to
c160220
Compare
kieron-dev
changed the title
kpack.Build deletion
As we need to support specifying secrets in different namespaces, we cannot instantiate the client with the credentials. Also extend to allow passing secrets via a service account's image pull secrets (ready for the kpack-image-builder usage). Co-authored-by: Kieron Browne <kbrowne@vmware.com>
We are about to use its Delete method to clean up droplets, so this refactor makes the client available and uses the image config inspection method to grab process details from the droplet. Issue: #2229 Co-authored-by: Kieron Browne <kbrowne@vmware.com>
This applies only to those Builds managed by korifi identified by having the korifi.cloudfoundry.org/build-workload-name label. Issue: #2229 Co-authored-by: Kieron Browne <kbrowne@vmware.com> Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
gcapizzi
force-pushed
the
issues/2229-delete-droplets
branch
from
c160220
to
425ed88
Compare
gcapizzi
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2229
What is this change about?
Korifi now reconciles kpack.Build resources with the
korifi.cloudfoundry.org/build-workload-namelabel set, i.e. those managed by korifi.It adds a finalizer that when triggered deletes the associated droplet image, if any, from the container registry.
As an associated refactor, we have used the same registry client library in the buildworkload reconciler to fetch image process details.
Does this PR introduce a breaking change?
No
Acceptance Steps
Push an app. Delete it. See the droplet images are removed from the container registry.
Tag your pair, your PM, and/or team
@gcapizzi