Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup droplets on kpack.Build deletion #2284

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Cleanup droplets on kpack.Build deletion #2284

merged 3 commits into from
Mar 16, 2023

Commits on Mar 16, 2023

  1. Image client creds now passed in method calls 

    As we need to support specifying secrets in different namespaces, we
cannot instantiate the client with the credentials.

Also extend to allow passing secrets via a service account's image pull
secrets (ready for the kpack-image-builder usage).

Co-authored-by: Kieron Browne <kbrowne@vmware.com>
    @gcapizzi
    gcapizzi and Kieron Browne committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0586936 View commit details
    Browse the repository at this point in the history

  2. Use the image.Client in the buildworkload controller 

    We are about to use its Delete method to clean up droplets, so this
refactor makes the client available and uses the image config inspection
method to grab process details from the droplet.

Issue: #2229
Co-authored-by: Kieron Browne <kbrowne@vmware.com>
    @gcapizzi
    gcapizzi and Kieron Browne committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6b54700 View commit details
    Browse the repository at this point in the history

  3. Cleanup droplet images when kpack.Build resources deleted 

    This applies only to those Builds managed by korifi identified by having
the korifi.cloudfoundry.org/build-workload-name label.

Issue: #2229
Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
    @gcapizzi
    Kieron Browne and gcapizzi committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    425ed88 View commit details
    Browse the repository at this point in the history