Fix: race condition in the v1 ingestor server tests #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a recurring race condition because of a goroutine that was running the `Pusher` method on manager, and the BeforeEach which would assign a new v1 `IngestorServer` to manager. This change stops the goroutine after it's not needed, and waits for it to close before completing the `It` test.
Now all tests will be run even if there is a failure.
Benjamintf1
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a recurring race condition because of a goroutine that was running the
Pushermethod on manager, and the BeforeEach which would assign a new v1IngestorServerto manager.This change stops the goroutine after it's not needed, and waits for it to close before completing the
Ittest.Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack