Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: race condition in the v1 ingestor server tests #468

Merged
merged 2 commits into from
Oct 18, 2022

Commits on Oct 17, 2022

  1. Fix race condition in the v1 ingestor server tests

    There was a recurring race condition because of a goroutine that was
    running the `Pusher` method on manager, and the BeforeEach which would
    assign a new v1 `IngestorServer` to manager.
    
    This change stops the goroutine after it's not needed, and waits for it
    to close before completing the `It` test.
    ctlong committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    fbcd67f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. CI: add keepGoing flag to Go / test job

    Now all tests will be run even if there is a failure.
    ctlong committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    8bde8fb View commit details
    Browse the repository at this point in the history