-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RND-168 Replace to Dell icons #2494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I think that the discussion under cloudify-ui-common#157 is crucial for this PR, I'll wait with the review till the discussion would be resolved
I've pinged @qooban about it, so we should be able to quickly tackle mentioned discussions, so that you wouldn't be stopped with progressing on finalizing tasks 💪
By the way, @leon-good-life there are lots of failing github pipelines - it would be worth to fix them before we'd do the review, as fixing them may reduce amount of comments from our side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @Vorbert-Kruk let's finalize cloudify-cosmo/cloudify-ui-common#157 first.
@qooban @Vorbert-Kruk The reason is that code will be shared across I guess this PR can be reviewed after the PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this PR can be reviewed after the PR in ui-common will be merged.
From my side it seems like a reasonable idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold on with this one until https://cloudifysource.atlassian.net/browse/RND-563 is ready so the Icon
component could be used instead of direct CSS references.
Description
Jira ticket: https://cloudifysource.atlassian.net/browse/RND-168
This PR can be merged after other PRs merged and published:
ui-common: cloudify-cosmo/cloudify-ui-common#157
part 2 ui-common: cloudify-cosmo/cloudify-ui-common#164
ui-components: https://github.com/cloudify-cosmo/cloudify-ui-components/pull/202
Screenshots / Videos
Latest screenshot:
New Upload file button in
cloudify-ui-components
:Checklist
Tests
Todo
Documentation
Todo