Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND-168 Replace to Dell icons #2494

Closed
wants to merge 25 commits into from
Closed

RND-168 Replace to Dell icons #2494

wants to merge 25 commits into from

Conversation

leon-good-life
Copy link
Contributor

@leon-good-life leon-good-life commented Mar 23, 2023

Description

Jira ticket: https://cloudifysource.atlassian.net/browse/RND-168

This PR can be merged after other PRs merged and published:

ui-common: cloudify-cosmo/cloudify-ui-common#157
part 2 ui-common: cloudify-cosmo/cloudify-ui-common#164
ui-components: https://github.com/cloudify-cosmo/cloudify-ui-components/pull/202

Screenshots / Videos

Latest screenshot:
Screenshot 2023-04-27 at 15 10 01

New Upload file button in cloudify-ui-components:
Screenshot 2023-03-29 at 8 55 41
Screenshot 2023-03-29 at 8 55 19
Screenshot 2023-03-29 at 8 55 31

Screenshot 2023-03-27 at 5 37 48

Screenshot 2023-03-28 at 19 06 15

Checklist

Tests

Todo

Documentation

Todo

@leon-good-life leon-good-life added the feature Pull request with non-breaking change adding new or enhancing already existing functionality label Mar 23, 2023
@leon-good-life leon-good-life changed the title RND-168 Replace Create Deployment, Execute Workflow and Update Deploy… RND-168 Replace to Dell icons Mar 23, 2023
@leon-good-life leon-good-life marked this pull request as ready for review March 29, 2023 02:11
Copy link
Contributor

@Vorbert-Kruk Vorbert-Kruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I think that the discussion under cloudify-ui-common#157 is crucial for this PR, I'll wait with the review till the discussion would be resolved

I've pinged @qooban about it, so we should be able to quickly tackle mentioned discussions, so that you wouldn't be stopped with progressing on finalizing tasks 💪

By the way, @leon-good-life there are lots of failing github pipelines - it would be worth to fix them before we'd do the review, as fixing them may reduce amount of comments from our side

Copy link
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @Vorbert-Kruk let's finalize cloudify-cosmo/cloudify-ui-common#157 first.

app/styles/style.scss Outdated Show resolved Hide resolved
app/widgets/common/inputs/DataTypesButton.tsx Outdated Show resolved Hide resolved
app/widgets/common/inputs/DefaultSortIcon.tsx Outdated Show resolved Hide resolved
@leon-good-life
Copy link
Contributor Author

@qooban @Vorbert-Kruk
I made additional PR in ui-common repository: cloudify-cosmo/cloudify-ui-common#164

The reason is that code will be shared across ui-components and stage.

I guess this PR can be reviewed after the PR in ui-common will be merged.

Copy link
Contributor

@Vorbert-Kruk Vorbert-Kruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this PR can be reviewed after the PR in ui-common will be merged.

From my side it seems like a reasonable idea

@kubama kubama self-requested a review May 8, 2023 08:13
Copy link
Contributor

@kubama kubama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold on with this one until https://cloudifysource.atlassian.net/browse/RND-563 is ready so the Icon component could be used instead of direct CSS references.

@qooban qooban removed their request for review June 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request with non-breaking change adding new or enhancing already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants