Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND-168 Add dell icons css file #157

Merged
merged 5 commits into from
Apr 19, 2023
Merged

RND-168 Add dell icons css file #157

merged 5 commits into from
Apr 19, 2023

Conversation

leon-good-life
Copy link
Contributor

@leon-good-life leon-good-life commented Mar 16, 2023

Description

Jira ticket: https://cloudifysource.atlassian.net/browse/RND-168

Other PRs

cloudify-cosmo/cloudify-stage#2494

Screenshots / Videos

Screenshot 2023-03-27 at 5 37 48

Checklist

Tests

N/A

Documentation

Will be done at the same time of finalising the PR in cloudify-tage.

@leon-good-life leon-good-life added the feature Pull request with non-breaking change adding new or enhancing already existing functionality label Mar 23, 2023
@leon-good-life leon-good-life marked this pull request as ready for review March 26, 2023 22:41
@Vorbert-Kruk
Copy link
Contributor

Vorbert-Kruk commented Mar 27, 2023

As @leon-good-life you may have some agreements with @qooban, when it comes to the implementation of dell's icons, I'd like to wait till @qooban would review this PR
I may have some suggestions already, but I'd want to make sure that they wouldn't be commented unnecessarily

Vorbert-Kruk
Vorbert-Kruk previously approved these changes Mar 30, 2023
@qooban
Copy link
Contributor

qooban commented Mar 30, 2023

@leon-good-life I talked with Alex M. today and I'd like to say: please don't worry about RND-168, it's not critical item, it's not planned for 7.0. Put work aside and spend time with your girlfriend and enjoy your vacation! 🙂

@Vorbert-Kruk
Copy link
Contributor

@leon-good-life I talked with Alex M. today and I'd like to say: please don't worry about RND-168, it's not critical item, it's not planned for 7.0. Put work aside and spend time with your girlfriend and enjoy your vacation! 🙂

Yeah, I'd say the same thing @leon-good-life
Enjoy your vacation and don't worry about the work stuff :)

@leon-good-life leon-good-life requested a review from qooban April 13, 2023 10:02
Copy link
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure how we will do the switch to DDS, but... not to block you I'm approving this PR.

@qooban
Copy link
Contributor

qooban commented Apr 14, 2023

@leon-good-life Before merging and releasing new minor version, please make sure it works properly with Stage.

@leon-good-life leon-good-life merged commit 18a30ed into master Apr 19, 2023
@leon-good-life leon-good-life deleted the RND-168 branch April 19, 2023 09:16
@leon-good-life leon-good-life restored the RND-168 branch April 27, 2023 10:17
@leon-good-life leon-good-life deleted the RND-168 branch April 27, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request with non-breaking change adding new or enhancing already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants