Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_type #103

Closed
wants to merge 2 commits into from
Closed

Conversation

drselump14
Copy link
Contributor

@drselump14 drselump14 commented Nov 21, 2022

what

  • Add build_type as codebuild option

why

  • build_type is required to utilize arm container

references

@drselump14 drselump14 requested review from a team as code owners November 21, 2022 05:34
@drselump14 drselump14 force-pushed the feature/add_build_type branch from f704eca to dd82c7e Compare January 30, 2023 09:59
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

@drselump14 Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@drselump14 drselump14 force-pushed the feature/add_build_type branch from 6da03c5 to 7724994 Compare March 3, 2024 23:04
@drselump14
Copy link
Contributor Author

@hans-d Hi, I've rebased the branch with the master branch

@hans-d
Copy link

hans-d commented Mar 4, 2024

@drselump14 if you can take care of the failing readme test as well?

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme
Error: Process completed with exit code 1.

@hans-d
Copy link

hans-d commented Mar 4, 2024

/terratest

@drselump14
Copy link
Contributor Author

/terratest

1 similar comment
@hans-d
Copy link

hans-d commented Mar 4, 2024

/terratest

@hans-d hans-d enabled auto-merge (squash) March 4, 2024 01:56
@drselump14
Copy link
Contributor Author

I added a PR #123 to fix the failing terratest @hans-d

@hans-d hans-d self-assigned this Mar 10, 2024
Copy link

mergify bot commented Mar 10, 2024

This pull request now has conflicts. Could you fix it @drselump14? 🙏

Copy link

mergify bot commented Mar 10, 2024

Thanks @drselump14 for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the conflict This PR has conflicts label Mar 10, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 17, 2024
Copy link

mergify bot commented Apr 8, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this Apr 8, 2024
auto-merge was automatically disabled April 8, 2024 17:32

Pull request was closed

@mergify mergify bot removed the conflict This PR has conflicts label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support build_type parameter
2 participants