Fix failing test

[drselump14]

what

Fix the failing test because outdated code

why

Test is failing on most of pull request

references

[hans-d]

/terratest

[drselump14]

updated the readme

[hans-d]

/terratest

[hans-d]

Likely failing tesrratest due to some of the ancient versions involved.
@drselump14 can you see if you can get some decent versions here? I wont be able to process that bit, but this issue in general has my attention and working on a cross-repo fix re how we call the tests and can run them more easily locally.

[drselump14]

@hans-d I updated the terraform versions to follow the versions on https://github.com/cloudposse/terraform-aws-vpc/blob/main/versions.tf

I only checked if terraform apply works on the examples folder. Not really sure how to invoke the test script as it's always failed with different errors on local

[hans-d]

Not really sure how to invoke the test script as it's always failed with different errors on local
no worries, we try to make that simpler (and better documented) as well.

[hans-d]

/terratest

[hans-d]

I'll have alook later re the failing test. Bit of a beast that one

[hans-d]

@drselump14 Hi, can you update the this

terraform-aws-ecs-codepipeline/examples/complete/versions.tf

Line 2 in 24ea735

required_version = ">= 0.13.0"

so that it want TF >= 1?

That should resolve the test from failing. (and we need a new readme)

[mergify]

This pull request now has conflicts. Could you fix it @drselump14? 🙏

[mergify]

Thanks @drselump14 for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[drselump14]

@drselump14 Hi, can you update the this

terraform-aws-ecs-codepipeline/examples/complete/versions.tf

Line 2 in 24ea735

required_version = ">= 0.13.0"

so that it want TF >= 1?

That should resolve the test from failing. (and we need a new readme)

Done ✅

[hans-d]

/terratest

[kevcube]

@drselump14 still failing, the error is a go error. I think possibly one output is not formatted as expected? I'll dig in later today.

[Roondel]

@drselump14 still failing, the error is a go error. I think possibly one output is not formatted as expected? I'll dig in later today.

@kevcube where you able to dig into this at all? I am fighting the same error on PR #121

what I saw when I tried to trigger the test locally using go cli was an error for unmarshalling the json:
FAIL: TestExamplesComplete (366.65s)
test_examples_complete_test.go:42:
Error Trace: test_examples_complete_test.go:42
Error: Received unexpected error:
json: cannot unmarshal string into Go value of type map[string]interface {}
Test: TestExamplesComplete
test_examples_complete_test.go:43:
Error Trace: test_examples_complete_test.go:43
Error: Not equal:
expected: string("geodesic")
actual : ()
Test: TestExamplesComplete
test_examples_complete_test.go:44:
Error Trace: test_examples_complete_test.go:44
Error: Not equal:
expected: string("cloudposse/geodesic")
actual : ()
Test: TestExamplesComplete
panic: interface conversion: interface {} is nil, not float64 [recovered]
panic: interface conversion: interface {} is nil, not float64

[kevcube]

@Roondel I think terratest needs to be upgraded in this repo. I will try that now

[kevcube]

/terratest

[kevcube]

removing no-release tag because we are updating a dependency

[gberenice]

🚀