upgrade aws provider #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AlyRagab Could you please adjust this for Terraform and for the providers? |
|
Here's an example cloudposse/terraform-aws-codebuild#70 |
aknysh
reviewed
Dec 6, 2020
versions.tf
Outdated
| @@ -2,7 +2,7 @@ terraform { | |||
| required_version = ">= 0.12.0, < 0.14.0" | |||
There was a problem hiding this comment.
Suggested change
| required_version = ">= 0.12.0, < 0.14.0" | |
| required_version = ">= 0.12.0" |
aknysh
reviewed
Dec 6, 2020
versions.tf
Outdated
| @@ -2,7 +2,7 @@ terraform { | |||
| required_version = ">= 0.12.0, < 0.14.0" | |||
|
|
|||
| required_providers { | |||
| aws = "~> 2.0" | |||
| aws = "~> 3.0" | |||
There was a problem hiding this comment.
Suggested change
| aws = "~> 3.0" | |
| aws = ">= 2.0" |
aknysh
reviewed
Dec 6, 2020
versions.tf
Outdated
| @@ -2,7 +2,7 @@ terraform { | |||
| required_version = ">= 0.12.0, < 0.14.0" | |||
|
|
|||
| required_providers { | |||
| aws = "~> 2.0" | |||
| aws = "~> 3.0" | |||
| null = "~> 2.0" | |||
There was a problem hiding this comment.
Suggested change
| null = "~> 2.0" | |
| null = "=> 2.0" |
|
Thanks @aknysh for your comments |
|
/test all |
aknysh
requested changes
Dec 6, 2020
There was a problem hiding this comment.
@AlyRagab
Sorry, but we also need to update the test to use Go modules.
Can you please run these commands:
make init
make github/init
cd test/src/
go mod init github.com/cloudposse/$(cd ../../ && basename `pwd`)
go mod tidy
git rm Gopkg.*
git add go.*
Thanks a lot for your contribution.
|
/rebuild-readme |
|
/test all |
…aws-vpn-connection into upgrade-aws-provider
|
/test all |
|
/rebuild-readme |
|
/test all |
|
/test all |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the aws provider version to be "~> 3.0" because the current "2.0" does not work if we have another resources depend on version 3.0
Error :
Initializing provider plugins...
Error: Failed to query available provider packages
Could not retrieve the list of available versions for provider hashicorp/aws:
no available releases match the given constraints ~> 3.0, ~> 2.0