Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.14 upgrade #9

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Terraform 0.14 upgrade #9

merged 2 commits into from
Dec 22, 2020

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Dec 21, 2020 •
edited by Nuru
Loading

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

  • Support Terraform 0.14

Supersedes and closes #8
Supersedes and closes #10

@maximmi maximmi requested review from Gowiem and aknysh December 21, 2020 11:08
@maximmi maximmi requested a review from a team as a code owner December 21, 2020 11:08
@maximmi
Copy link
Contributor Author

maximmi commented Dec 21, 2020

/test all

@Nuru
Copy link
Contributor

Nuru commented Dec 21, 2020

/test ping all

1 similar comment
@Nuru
Copy link
Contributor

Nuru commented Dec 21, 2020

/test ping all

@Nuru Nuru added the patch A minor, backward compatible change label Dec 21, 2020
@Nuru Nuru self-requested a review December 21, 2020 21:56
Nuru
Nuru previously approved these changes Dec 21, 2020
View reviewed changes
@Nuru Nuru dismissed their stale review December 21, 2020 21:58

Bad style

@maximmi maximmi requested a review from a team as a code owner December 21, 2020 22:02
@Nuru
Copy link
Contributor

Nuru commented Dec 21, 2020

/test all

@Nuru
Copy link
Contributor

Nuru commented Dec 21, 2020

@maximmi The local.enabled pattern is fine to keep, and preferred when there are lots of usages. When converting from var.enabled, you can use either local.enabled or module.this.enabled.

@maximmi maximmi merged commit 7c0c60a into master Dec 22, 2020
@maximmi maximmi deleted the terraform-0.14-upgrade branch December 22, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximmi @Nuru