Add option to specify filename for instances in GameInstanceGenerator (cleaned) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 17:23
….generate(), default is set to instances.json to allow for backward compatibility
|
dropped an unrelated commit from #38 |
phisad
added a commit
that referenced
this pull request
Feb 8, 2024
… (cleaned) (#44) * add option to specify filename for instances in GameInstanceGenerator.generate(), default is set to instances.json to allow for backward compatibility * inline no where else used storing function --------- Co-authored-by: Anne Beyer <anne.beyer@uni-potsdam.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards #12, GameInstanceGenerator.generate() can now be given a file name to create different versions of instances in in/ (default is set to "instances.json" as before)