Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify filename for instances in GameInstanceGenerator (cleaned) #44

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add option to specify filename for instances in GameInstanceGenerator (cleaned) #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106f340
add option to specify filename for instances in GameInstanceGenerator…
Jan 29, 2024
063c97c
inline no where else used storing function
Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions clemgame/clemgame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,12 +838,9 @@ def add_game_instance(self, experiment: Dict, game_id):
def on_generate(self):
raise NotImplementedError()

def generate(self):
def generate(self, filename="instances.json"):
self.on_generate()
self.store()

def store(self):
self.store_file(self.instances, "instances.json", sub_dir="in")
self.store_file(self.instances, filename, sub_dir="in")


def load_benchmarks(do_setup: bool = True) -> List[GameBenchmark]:
Expand Down