Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Operations Synthetic #7743

Merged
merged 20 commits into from
Dec 30, 2024
Merged

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Dec 5, 2024

About the pull request

This PR adds a ship oriented Synthetic who is playable if there is no Survivor Synthetic present.

Issue at hand was although Synthetics readily accept RP, they are not able to easily go out of their way to initiate it due to their responsibilities outside of 3 phases: Pre-drop, Surgery, Post-drop.

This is a push to better incentivize the availability of Synthetics to RP. Currently they are burdened with a multitude of responsibilities compared to other roles which are able to prioritize RP. This effectively bridges that gap significantly, and encourages RP whilst by having 1 Synthetic operate more in-line with the bridge officer / ship maintenance synthetic within the bounds of lore.

BIG Thanks to Drathek for the role authority code!!!

Great suggestion by Beagle!!

Explain why it's good for the game

Conducive to RP availability and pretty healthy for immersion within lore. Does not change the overall amount of Synthetics.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

image

image

image

image

built ok

Changelog

🆑
add: Adds the Ship Operations Synthetic. This ship-oriented Synthetic assists the USS Almayer with various tasks and improves the atmosphere of the vessel, they maintain the entire ship and act as its pilot. This role is enabled if there is no Survivor Synthetic present. Huge thanks to Drathek for roleauthority code!
add: Changes role selection color of WJ to be slightly darker to differentiate from Synthetics.
code: restructured lobby role selection menu to accomadate new role
/:cl:

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 5, 2024
@dryramen2
Copy link

looking at the code, it looks like it's only changing available synth slots to 2? how would the synth players know it's a shipside only slot?

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 5, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Dec 5, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 5, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@QuickLode QuickLode changed the title Second Synthetic Slot for Shipside Only (RP Incentive) Ship Operations Synthetic (RP Incentive) Dec 5, 2024
@Diegoflores31

This comment was marked as off-topic.

@Drulikar Drulikar marked this pull request as draft December 6, 2024 02:25
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
@cmss13-ci cmss13-ci bot added the Removal snap label Dec 6, 2024
@QuickLode QuickLode marked this pull request as ready for review December 6, 2024 15:56
@QuickLode

This comment was marked as resolved.

@QuickLode QuickLode requested a review from Drulikar December 6, 2024 16:34
@QuickLode QuickLode changed the title Ship Operations Synthetic (RP Incentive) Ship Operations Synthetic Dec 6, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 27, 2024
@Drulikar Drulikar added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Dec 30, 2024
@Drulikar Drulikar enabled auto-merge December 30, 2024 20:54
@Drulikar Drulikar added this pull request to the merge queue Dec 30, 2024
Merged via the queue into cmss13-devs:master with commit f98918d Dec 30, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Dec 30, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
# About the pull request
This PR adds a ship oriented Synthetic who is playable if there is no
Survivor Synthetic present.

Issue at hand was although Synthetics readily accept RP, they are not
able to easily go out of their way to initiate it due to their
responsibilities outside of 3 phases: Pre-drop, Surgery, Post-drop.

This is a push to better incentivize the availability of Synthetics to
RP. Currently they are burdened with a multitude of responsibilities
compared to other roles which are able to prioritize RP. This
effectively bridges that gap significantly, and encourages RP whilst by
having 1 Synthetic operate more in-line with the bridge officer / ship
maintenance synthetic within the bounds of lore.

BIG Thanks to Drathek for the role authority code!!!

Great suggestion by Beagle!!
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Conducive to RP availability and pretty healthy for immersion within
lore. Does not change the overall amount of Synthetics.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.


![image](https://github.com/user-attachments/assets/7ae830f4-0e7f-4ddb-b83d-2d98006f8391)


![image](https://github.com/user-attachments/assets/d1b51c8c-fc1e-4c05-8556-1f57a72fc946)


![image](https://github.com/user-attachments/assets/c61b9f65-0093-428f-94f0-e9b75b813c32)


![image](https://github.com/user-attachments/assets/5cadf7d3-b005-47b6-a17b-70b606514631)




built ok 
</details>


# Changelog
:cl:
add: Adds the Ship Operations Synthetic. This ship-oriented Synthetic
assists the USS Almayer with various tasks and improves the atmosphere
of the vessel, they maintain the entire ship and act as its pilot. This
role is enabled if there is no Survivor Synthetic present. Huge thanks
to Drathek for roleauthority code!
add: Changes role selection color of WJ to be slightly darker to
differentiate from Synthetics.
code: restructured lobby role selection menu to accomadate new role
/:cl:

---------

Co-authored-by: Drulikar <drathek@gmail.com>
Co-authored-by: harryob <me@harryob.live>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Removal snap
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

8 participants