-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship Operations Synthetic #7743
Merged
Drulikar
merged 20 commits into
cmss13-devs:master
from
QuickLode:2nd-shipside-synth-rp
Dec 30, 2024
Merged
Ship Operations Synthetic #7743
Drulikar
merged 20 commits into
cmss13-devs:master
from
QuickLode:2nd-shipside-synth-rp
Dec 30, 2024
+99
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
the
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
label
Dec 5, 2024
looking at the code, it looks like it's only changing available synth slots to 2? how would the synth players know it's a shipside only slot? |
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Dec 5, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Dec 5, 2024
Conflicts have been resolved. A maintainer will review the pull request shortly. |
QuickLode
changed the title
Second Synthetic Slot for Shipside Only (RP Incentive)
Ship Operations Synthetic (RP Incentive)
Dec 5, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
…cmss13 into 2nd-shipside-synth-rp
TheGamerdk
reviewed
Dec 5, 2024
Drulikar
previously requested changes
Dec 6, 2024
This comment was marked as resolved.
This comment was marked as resolved.
QuickLode
changed the title
Ship Operations Synthetic (RP Incentive)
Ship Operations Synthetic
Dec 6, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 24, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 24, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 24, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 25, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 25, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 25, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 25, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 25, 2024
This was referenced Dec 26, 2024
cm13-github
added a commit
that referenced
this pull request
Dec 27, 2024
This was referenced Dec 27, 2024
Drulikar
added
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
and removed
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Needs Testing
Need to test it on the guinea pigs (production server)
labels
Dec 30, 2024
Drulikar
approved these changes
Dec 30, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Dec 31, 2024
# About the pull request This PR adds a ship oriented Synthetic who is playable if there is no Survivor Synthetic present. Issue at hand was although Synthetics readily accept RP, they are not able to easily go out of their way to initiate it due to their responsibilities outside of 3 phases: Pre-drop, Surgery, Post-drop. This is a push to better incentivize the availability of Synthetics to RP. Currently they are burdened with a multitude of responsibilities compared to other roles which are able to prioritize RP. This effectively bridges that gap significantly, and encourages RP whilst by having 1 Synthetic operate more in-line with the bridge officer / ship maintenance synthetic within the bounds of lore. BIG Thanks to Drathek for the role authority code!!! Great suggestion by Beagle!! <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Conducive to RP availability and pretty healthy for immersion within lore. Does not change the overall amount of Synthetics. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. ![image](https://github.com/user-attachments/assets/7ae830f4-0e7f-4ddb-b83d-2d98006f8391) ![image](https://github.com/user-attachments/assets/d1b51c8c-fc1e-4c05-8556-1f57a72fc946) ![image](https://github.com/user-attachments/assets/c61b9f65-0093-428f-94f0-e9b75b813c32) ![image](https://github.com/user-attachments/assets/5cadf7d3-b005-47b6-a17b-70b606514631) built ok </details> # Changelog :cl: add: Adds the Ship Operations Synthetic. This ship-oriented Synthetic assists the USS Almayer with various tasks and improves the atmosphere of the vessel, they maintain the entire ship and act as its pilot. This role is enabled if there is no Survivor Synthetic present. Huge thanks to Drathek for roleauthority code! add: Changes role selection color of WJ to be slightly darker to differentiate from Synthetics. code: restructured lobby role selection menu to accomadate new role /:cl: --------- Co-authored-by: Drulikar <drathek@gmail.com> Co-authored-by: harryob <me@harryob.live> Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Code Improvement
Make the code longer
Feature
Feature coder badge
Removal
snap
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds a ship oriented Synthetic who is playable if there is no Survivor Synthetic present.
Issue at hand was although Synthetics readily accept RP, they are not able to easily go out of their way to initiate it due to their responsibilities outside of 3 phases: Pre-drop, Surgery, Post-drop.
This is a push to better incentivize the availability of Synthetics to RP. Currently they are burdened with a multitude of responsibilities compared to other roles which are able to prioritize RP. This effectively bridges that gap significantly, and encourages RP whilst by having 1 Synthetic operate more in-line with the bridge officer / ship maintenance synthetic within the bounds of lore.
BIG Thanks to Drathek for the role authority code!!!
Great suggestion by Beagle!!
Explain why it's good for the game
Conducive to RP availability and pretty healthy for immersion within lore. Does not change the overall amount of Synthetics.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.built ok
Changelog
🆑
add: Adds the Ship Operations Synthetic. This ship-oriented Synthetic assists the USS Almayer with various tasks and improves the atmosphere of the vessel, they maintain the entire ship and act as its pilot. This role is enabled if there is no Survivor Synthetic present. Huge thanks to Drathek for roleauthority code!
add: Changes role selection color of WJ to be slightly darker to differentiate from Synthetics.
code: restructured lobby role selection menu to accomadate new role
/:cl: