Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes non combat click delay #7802

Merged
merged 20 commits into from
Dec 31, 2024
Merged

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Dec 12, 2024

About the pull request

Basically #2130 but coded differently

Explain why it's good for the game

#2130

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
del: Removed non-combat click delay, interacting with items not on your person should be significantly smoother
balance: Clicking on the floor (open turfs) with an item will no longer cause a click delay
/:cl:

@cmss13-ci cmss13-ci bot added Removal snap Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Dec 12, 2024
cm13-github added a commit that referenced this pull request Dec 12, 2024
cm13-github added a commit that referenced this pull request Dec 12, 2024
cm13-github added a commit that referenced this pull request Dec 12, 2024
fira
fira previously requested changes Dec 12, 2024
code/_onclick/click.dm Outdated Show resolved Hide resolved
code/_onclick/click.dm Outdated Show resolved Hide resolved
code/_onclick/item_attack.dm Show resolved Hide resolved
code/__DEFINES/_click.dm Outdated Show resolved Hide resolved
code/_onclick/click.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar dismissed their stale review December 12, 2024 21:15

Resolved

cm13-github added a commit that referenced this pull request Dec 12, 2024
@Ansekishokuu
Copy link
Contributor

issue with being able to destroy a pylon with no cooldown between attacks (bayonet slash in this instance, observed as a marine destroyed the pylon in a second)

and a very minor issue with health analyzers being able to scan very fast.

cm13-github added a commit that referenced this pull request Dec 13, 2024
cm13-github added a commit that referenced this pull request Dec 13, 2024
cm13-github added a commit that referenced this pull request Dec 13, 2024
cm13-github added a commit that referenced this pull request Dec 13, 2024
cm13-github added a commit that referenced this pull request Dec 13, 2024
@Drulikar
Copy link
Contributor

issue with being able to destroy a pylon with no cooldown between attacks (bayonet slash in this instance, observed as a marine destroyed the pylon in a second)

and a very minor issue with health analyzers being able to scan very fast.

Pylon attacking should already be resolved. Health analyzers are not.

cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
@Blundir
Copy link
Contributor

Blundir commented Dec 25, 2024

also you can spam hand/zip cuffs very fast now, spamming sound like crazy

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Watermelon914
Copy link
Contributor

Watermelon914 commented Dec 27, 2024

these can probably be fixed post merge, they don't seem super critical. I'd say only block merge for anything that leads to gamebreaking bugs or similar

@Git-Nivrak Git-Nivrak marked this pull request as ready for review December 28, 2024 09:32
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks fine

code/_onclick/click.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Dec 31, 2024
@Drulikar Drulikar added this pull request to the merge queue Dec 31, 2024
Merged via the queue into cmss13-devs:master with commit 9b17397 Dec 31, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Dec 31, 2024
Git-Nivrak added a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
# About the pull request
Basically cmss13-devs#2130 but coded differently
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
cmss13-devs#2130
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
del: Removed non-combat click delay, interacting with items not on your
person should be significantly smoother
balance: Clicking on the floor (open turfs) with an item will no longer
cause a click delay
/:cl:

---------

Co-authored-by: harryob <me@harryob.live>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Needs Testing Need to test it on the guinea pigs (production server) Removal snap Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.