Feature: CNF Installation (4) Group several manifest into one file #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svteb
reviewed
Sep 9, 2024
src/tasks/cleanup.cr
Outdated
Comment on lines
43
to
48
| # Remove common_manifest.yaml file | ||
| common_manifest_path = "cnfs/common_manifest.yaml" | ||
| if File.exists?(common_manifest_path) | ||
| File.delete(common_manifest_path) | ||
| stdout_success "#{common_manifest_path} file deleted successfully." | ||
| end |
There was a problem hiding this comment.
This stdout_success feels unnecessary, should just be a Log.info.
src/tasks/utils/cnf_manager.cr
Outdated
Comment on lines
885
to
901
|
|
||
| #Generating manifest from installed CNF | ||
| generated_manifest = Helm.generate_manifest(release_name, deployment_namespace) | ||
| manifest_path = "cnfs/common_manifest.yaml" | ||
| if File.exists?(manifest_path) | ||
| File.open(manifest_path, "a") do |file| | ||
| file.puts generated_manifest | ||
| end | ||
| else | ||
| File.open(manifest_path, "w") do |file| | ||
| file.puts generated_manifest | ||
| end | ||
| end |
There was a problem hiding this comment.
This should have some exception handling/verification of the returned value (i.e. string not empty).
|
The Helm module change that this ticket depends on should be mentioned/referenced somewhere in the pull request, possibly even in the commit. Additionally changing the title to conform to the other pull requests from the epic would be appreciated for clarity. |
barmull
changed the title
barmull
force-pushed
the
manifest
branch
6 times, most recently
from
2f62d28
to
50ce8b2
Compare
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4
|
Recreated in PR: #2150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on
Pull request from helm library: cnf-testsuite/helm#4
Issues:
Refs: #2125
How has this been tested: