Feature: CNF Installation (4) Group several manifest into one file #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
barmull
force-pushed
the
#2125-create-common-manifest
branch
2 times, most recently
from
3a123e2
to
0d92ced
Compare
svteb
reviewed
Sep 24, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
0d92ced
to
370c35f
Compare
kosstennbl
requested changes
Sep 26, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
2 times, most recently
from
8bdf96c
to
552616c
Compare
martin-mat
requested changes
Sep 30, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
dc84367
to
9713630
Compare
martin-mat
requested changes
Oct 3, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
d57ddca
to
0a83d77
Compare
|
Tested, found some mistakes: common_manifest is not deleted on cnf_cleanup (should be) |
Adapt all usages of config to the new format. Remove code that was used by old config. Update all sample and example configs. Refs: #2135 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
ba61349
to
cebe752
Compare
svteb
reviewed
Oct 8, 2024
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4 - common_manifest functionality: used common_manifest instead of templates - remove methods related to templates Signed-off-by: barmull <barbora.muller@tietoevry.com>
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
cebe752
to
f4021c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues:
Refs: #2125
Re-created from different branch, old PR: #2144