Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: CNF Installation (3) Switch to new config usage #2149

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

kosstennbl
Copy link
Collaborator

Description

Adapt all usages of config to the new config v2 format.
Remove code that was used by old config, but serves no purpose with new config version.
Update all sample and example configs, use transformer if cnf_setup is called with non-latest version.

Issues:

Refs: #2135

CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
example-cnfs/nsm/cnf-testsuite.yml Show resolved Hide resolved
@kosstennbl kosstennbl force-pushed the #2135-switch-to-new-config branch 4 times, most recently from dda4ac0 to 8eaee0e Compare September 24, 2024 07:59
@kosstennbl kosstennbl force-pushed the #2135-switch-to-new-config branch 2 times, most recently from bfe48fc to 7d9bea3 Compare September 30, 2024 07:21
@kosstennbl kosstennbl marked this pull request as ready for review September 30, 2024 07:21
@kosstennbl kosstennbl force-pushed the #2135-switch-to-new-config branch 7 times, most recently from 81fae4c to 448764e Compare September 30, 2024 12:14
@kosstennbl
Copy link
Collaborator Author

List of changes:

Most of changed *.cr files: adapt to new config (parsing, usage), won't be mentioned below.

  • Workflow: use example from current commit, not main. (possibly could be moved out of PR)
  • CNF_TESTSUITE_YML_USAGE.md: update docs for CNF config.
  • embedded files: add config examples for different versions
  • example/sample_cnfs: update to new format via config updater. Some manual modifications where was needed. Removal of some unused parameters.
  • setup spec: removal of genereate_config tests as the process is now interactive. Add test for setup of v1 config.
  • cnf_manager_spec: remove unneccessary tests.
  • cnf_setup: replace generator, small naming changes
  • constants: move rolling version tags outside of specific file. (Was planned to be used in config, redesigned later)
  • setup: replace config validation task
  • cnf_install/config: add updater to parsing, move and adapt some methods from old config
  • install_common: remove functions which are not needed anymore
  • cnf_manager: remove not needed functions, remove HelmDirectoryMissing exception (was used only as warning)
  • config.cr, generate_config.cr: were deleted, fully replaced with v2 versions
  • task: redone config generation for platform tests
  • compatibility: move constant array to constants, removed validation (now in setup).
  • state: redesign elastic_volumes test to not use Helm.kind_exists? (this Helm library method took testsuite config as argument. While writing this comment, i reminded myself of this, want to tear my hair once more)

@kosstennbl kosstennbl force-pushed the #2135-switch-to-new-config branch 2 times, most recently from ecd7158 to 5584abf Compare October 3, 2024 08:37
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
CNF_TESTSUITE_YML_USAGE.md Outdated Show resolved Hide resolved
spec/workload/state_spec.cr Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_manager.cr Outdated Show resolved Hide resolved
Adapt all usages of config to the new format.
Remove code that was used by old config.
Update all sample and example configs.

Refs: #2135
Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit d96866b into main Oct 8, 2024
85 checks passed
@kosstennbl kosstennbl deleted the #2135-switch-to-new-config branch October 9, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants