server/debug: TestAdminDebugRedirect failed #120095
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-1
Issues/test failures with a fix SLA of 1 month
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
Comments
cockroach-teamcity
added
branch-master
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
Mar 18, 2024
Adjusts test to use more standard redirect ignorig behavior in stdlib, and removes the test tenant override since this test works with tenants now after some adjustements to URL handling. The cockroachdb#120095 issue was a timeout that this change doesn't explicitly deal with here since that problem isn't reproducible. The hope is that modified redirect error handling might trigger a less error-prone branch in the HTTP-client. There's nothing else to really change in this test since it's quite simple and we haven't seen similar timeouts persist in other HTTP tests. Resolves: cockroachdb#120095 Resolves: cockroachdb#112955 Epic: None Release note: None
craig bot
pushed a commit
that referenced
this issue
Mar 19, 2024
120410: sql: allow additional fmt flags for stmt fingerprinting r=xinhaoz a=xinhaoz This commit introduces a way to add additional format flags when formatting a statement AST into its statement fingerprint representation for sql stats. This allows us to more aggressively generalize the statement fingerprint. `sql.stats.statement_fingerprint.format_mask` will be used to supply these additional flags to the formatter. It is currently 0 by default since no new flags for fingerprints have been added. Epic: none Part of: #120409 Release note: None 120646: telemetryccl: use log spy in backup/restore test r=abarganier a=dhartunian Previously this test used file logging to test the telemetry output, which can result in flakes on CI. This commit modifies the test to use a log spy which is a bit more reliable. Additionally, the deserialization now happens in the `Intercept()` method which makes the test easier to read. Resolves: #120115 Epic: None Release note: None 120653: server: refactor TestAdminDebugRedirect test r=abarganier a=dhartunian Adjusts test to use more standard redirect ignoring behavior in stdlib, and removes the test tenant override since this test works with tenants now after some adjustments to URL handling. The #120095 issue was a timeout that this change doesn't explicitly deal with here since that problem isn't reproducible. The hope is that modified redirect error handling might trigger a less error-prone branch in the HTTP-client. There's nothing else to really change in this test since it's quite simple and we haven't seen similar timeouts persist in other HTTP tests. Resolves: #120095 Resolves: #112955 Epic: None Release note: None 120699: sql: skip TestSqlActivityUpdateTopLimitJob r=abarganier a=dhartunian Release note: None 120715: workflows: tag `cockroach` builds for integration tests r=rail a=rickystewart ... with the tag `integration-test-artifact-build`. We do this to track how long it takes to build these artifacts specifically. Epic: CRDB-8308 Release note: None Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
server/debug.TestAdminDebugRedirect failed with artifacts on master @ 559994e230ac3776dd1188e66678cce9205ab345:
Fatal error:
Stack:
Log preceding fatal error
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-36471
The text was updated successfully, but these errors were encountered: