Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ccl/telemetryccl/telemetryccl_test: TestBulkJobTelemetryLogging failed #120115

Closed
cockroach-teamcity opened this issue Mar 8, 2024 · 0 comments · Fixed by #120646
Closed
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 8, 2024

pkg/ccl/telemetryccl/telemetryccl_test.TestBulkJobTelemetryLogging failed with artifacts on master @ 559994e230ac3776dd1188e66678cce9205ab345:

=== RUN   TestBulkJobTelemetryLogging
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/c0a2fc110ea828b880ad17bdbc321aac/logTestBulkJobTelemetryLogging2605397226
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.

pkg/ccl/telemetryccl/telemetryccl_test/pkg/ccl/telemetryccl/telemetry_logging_test.go:420: (waitForJobResult)
	NOTICE: .JobRegistry() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().JobRegistry() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization
    telemetry_logging_test.go:320: finished:"IMPORT INTO a CSV DATA ('http://127.0.0.1:33955')"
    telemetry_logging_test.go:320: finished:"IMPORT INTO a CSV DATA ('http://127.0.0.1:33955') WITH detached"
    telemetry_logging_test.go:320: finished:"BACKUP DATABASE mydb INTO 'nodelocal://1/test1'"
    telemetry_logging_test.go:320: finished:"BACKUP DATABASE mydb INTO 'nodelocal://1/test1' WITH detached"
    telemetry_logging_test.go:320: finished:"RESTORE DATABASE mydb FROM LATEST IN 'nodelocal://1/test1'"
    telemetry_logging_test.go:320: finished:"RESTORE DATABASE mydb FROM LATEST IN 'nodelocal://1/test1' WITH detached"
    telemetry_logging_test.go:414: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/c0a2fc110ea828b880ad17bdbc321aac/logTestBulkJobTelemetryLogging2605397226
--- FAIL: TestBulkJobTelemetryLogging (12.24s)
=== RUN   TestBulkJobTelemetryLogging/backup
    telemetry_logging_test.go:405: 
        	Error Trace:	pkg/ccl/telemetryccl/telemetryccl_test/pkg/ccl/telemetryccl/telemetry_logging_test.go:405
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 0
        	Test:       	TestBulkJobTelemetryLogging/backup
    --- FAIL: TestBulkJobTelemetryLogging/backup (0.00s)

Parameters:

  • TAGS=bazel,gss,deadlock
  • stress=true
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-inf-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-36490

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability-inf labels Mar 8, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Mar 8, 2024
@dhartunian dhartunian added the P-1 Issues/test failures with a fix SLA of 1 month label Mar 11, 2024
dhartunian added a commit to dhartunian/cockroach that referenced this issue Mar 18, 2024
Previously this test used file logging to test the telemetry output,
which can result in flakes on CI. This commit modifies the test to use
a log spy which is a bit more reliable. Additionally, the
deserialization now happens in the `Intercept()` method which makes
the test easier to read.

Resolves: cockroachdb#120115
Epic: None
Release note: None
@dhartunian dhartunian self-assigned this Mar 18, 2024
craig bot pushed a commit that referenced this issue Mar 19, 2024
120410: sql: allow additional fmt flags for stmt fingerprinting r=xinhaoz a=xinhaoz

This commit introduces a way to add additional format flags when
formatting a statement AST into its statement fingerprint representation
for sql stats. This allows us to more aggressively generalize the
statement fingerprint.

`sql.stats.statement_fingerprint.format_mask` will be used to supply
these additional flags to the formatter.  It is currently 0 by default
since no new flags for fingerprints have been added.

Epic: none
Part of: #120409

Release note: None

120646: telemetryccl: use log spy in backup/restore test r=abarganier a=dhartunian

Previously this test used file logging to test the telemetry output, which can result in flakes on CI. This commit modifies the test to use a log spy which is a bit more reliable. Additionally, the deserialization now happens in the `Intercept()` method which makes the test easier to read.

Resolves: #120115
Epic: None
Release note: None

120653: server: refactor TestAdminDebugRedirect test r=abarganier a=dhartunian

Adjusts test to use more standard redirect ignoring behavior in stdlib, and removes the test tenant override since this test works with tenants now after some adjustments to URL handling.

The #120095 issue was a timeout that this change doesn't explicitly deal with here since that problem isn't reproducible. The hope is that modified redirect error handling might trigger a less error-prone branch in the HTTP-client. There's nothing else to really change in this test since it's quite simple and we haven't seen similar timeouts persist in other HTTP tests.

Resolves: #120095
Resolves: #112955
Epic: None

Release note: None

120699: sql: skip TestSqlActivityUpdateTopLimitJob r=abarganier a=dhartunian

Release note: None

120715: workflows: tag `cockroach` builds for integration tests r=rail a=rickystewart

... with the tag `integration-test-artifact-build`. We do this to track how long it takes to build these artifacts specifically.

Epic: CRDB-8308
Release note: None

Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com>
Co-authored-by: David Hartunian <davidh@cockroachlabs.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in cffcc30 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants