backupccl: actually enable stats at end of download job #119955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-or-fix-stats
branch
3 times, most recently
from
0d8b814
to
78f6c43
Compare
msbutler
force-pushed
the
butler-or-fix-stats
branch
2 times, most recently
from
307af43
to
adf4906
Compare
msbutler
commented
Mar 6, 2024
msbutler
force-pushed
the
butler-or-fix-stats
branch
from
adf4906
to
c52ddf6
Compare
stevendanna
reviewed
Mar 8, 2024
msbutler
force-pushed
the
butler-or-fix-stats
branch
2 times, most recently
from
e738de1
to
85e3ba1
Compare
stevendanna
reviewed
Mar 12, 2024
msbutler
force-pushed
the
butler-or-fix-stats
branch
3 times, most recently
from
f547720
to
61eec83
Compare
dt
approved these changes
Mar 14, 2024
msbutler
force-pushed
the
butler-or-fix-stats
branch
2 times, most recently
from
1b8b14e
to
4ab0443
Compare
Previously, the download job would be written before publishing sql descriptors in the linking job. This meant that the download job could finish before the descriptors were published. Since we attempt to manipulate descriptors at the end of the download job (to re-enable auto stats jobs on restored tables), the link job could fail if it observed that the restored descriptors were modified before they were published. This patch also fixes another bug where cluster online restore would write two download jobs with the same ID. Previously, the download job would be written at the end of the `restoreWithRetry()` call. Note that during cluster restore we call this twice-- once for certain important system tables and again for the main restoration data. This patch creates a single download job that will track the downloading of all spans involved in the cluster restore. Epic: none Release note: none
PR cockroachdb#116977 didn't re-enable auto stats collection for online restored tables after the download job. This patch fixes this bug. Fixes cockroachdb#119935 Release note: none
msbutler
force-pushed
the
butler-or-fix-stats
branch
from
4ab0443
to
af477d4
Compare
|
TFTR! bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #116977 didn't re-enable auto stats collection for online restored tables
after the download job. This patch fixes this bug.
Fixes #119935
Release note: none