Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: fix sql stats re-enablement in online restore #119935

Closed
msbutler opened this issue Mar 5, 2024 · 3 comments · Fixed by #119955
Closed

backupccl: fix sql stats re-enablement in online restore #119935

msbutler opened this issue Mar 5, 2024 · 3 comments · Fixed by #119955
Assignees
Labels
A-disaster-recovery branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Mar 5, 2024

For the download job, we temporarily disable sql stats computation, and re-enable it here once the download job completes. This re-enablement code doesn't actually do anything because we dont pass the list of restoring table descriptors to the download job.

Jira issue: CRDB-36399

@msbutler msbutler added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery GA-blocker labels Mar 5, 2024
Copy link

blathers-crl bot commented Mar 5, 2024

cc @cockroachdb/disaster-recovery

Copy link

blathers-crl bot commented Mar 5, 2024

Hi @msbutler, please add branch-* labels to identify which branch(es) this GA-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@msbutler msbutler added the branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 label Mar 5, 2024
@exalate-issue-sync exalate-issue-sync bot removed A-disaster-recovery T-disaster-recovery GA-blocker branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 labels Mar 5, 2024
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 6, 2024
PR cockroachdb#116977 didn't re-enable auto stats collection for online restored tables
after the download job. This patch fixes this bug.

Fixes cockroachdb#119935

Release note: none
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 6, 2024
PR cockroachdb#116977 didn't re-enable auto stats collection for online restored tables
after the download job. This patch fixes this bug.

Fixes cockroachdb#119935

Release note: none
@exalate-issue-sync exalate-issue-sync bot added A-disaster-recovery T-disaster-recovery GA-blocker branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 labels Mar 11, 2024
Copy link

blathers-crl bot commented Mar 11, 2024

cc @cockroachdb/disaster-recovery

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Mar 11, 2024
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 14, 2024
PR cockroachdb#116977 didn't re-enable auto stats collection for online restored tables
after the download job. This patch fixes this bug.

Fixes cockroachdb#119935

Release note: none
craig bot pushed a commit that referenced this issue Mar 15, 2024
119955: backupccl: actually enable stats at end of download job r=dt a=msbutler

PR #116977 didn't re-enable auto stats collection for online restored tables
after the download job. This patch fixes this bug.

Fixes #119935

Release note: none

120475: server: include license expiration type and time into `uiconfig` response r=koorosh a=koorosh

This change extends response for `uiconfig` endpoint which now contains information about license type and time until license expires.

Related: #98589

Release note: None

Epic: None

Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
@craig craig bot closed this as completed in af477d4 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery
Projects
Development

Successfully merging a pull request may close this issue.

1 participant