-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: show license expiration alert in Db Console #120490
ui: show license expiration alert in Db Console #120490
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
cc @innabs , lmk if text of alerts of visual representation should be changed. Currently, default alerts are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @koorosh, and @xinhaoz)
-- commits
line 11 at r1:
nit: include the days to expiry threshold in the release note.
pkg/ui/workspaces/db-console/src/redux/alerts.ts
line 700 at r1 (raw file):
default: return "None"; }
maybe better as a map?
cd24026
to
11d50c2
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @abarganier, @dhartunian, and @xinhaoz)
Previously, dhartunian (David Hartunian) wrote…
nit: include the days to expiry threshold in the release note.
Done.
pkg/ui/workspaces/db-console/src/redux/alerts.ts
line 700 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
maybe better as a map?
Done.
f003b92
to
7542fb0
Compare
With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire. This change doesn't affect clusters that doesn't have any license set. Release note (ui change): show alert message in Db Console when license is expired or less than 15 days left before it expires.
7542fb0
to
006838d
Compare
bors r+ |
Build succeeded: |
With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire.
This change doesn't affect clusters that doesn't have any license set.
Release note (ui change): show alert message in Db Console when license is expired or close to expire.
Depends on: #120475
Resolves: #98589
Epic: None
Screens: