server: include license expiration type and time into uiconfig response
#120475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
koorosh
force-pushed
the
ui-license-expiration-ttl
branch
from
ac040d3
to
9ea2850
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
dhartunian
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @koorosh, and @xinhaoz)
-- commits line 2 at r1:
nit: length. wrap at 80 chars.
koorosh
force-pushed
the
ui-license-expiration-ttl
branch
from
9ea2850
to
8060144
Compare
koorosh
commented
Mar 15, 2024
There was a problem hiding this comment.
Reviewable status:
Previously, dhartunian (David Hartunian) wrote…
nit: length. wrap at 80 chars.
Done.
koorosh
force-pushed
the
ui-license-expiration-ttl
branch
from
8060144
to
ad8b3a9
Compare
This change extends response for `uiconfig` endpoint which now contains information about license type and time until license expires. Release note: None
koorosh
force-pushed
the
ui-license-expiration-ttl
branch
from
ad8b3a9
to
000764b
Compare
|
bors r+ |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
120490: ui: show license expiration alert in Db Console r=koorosh a=koorosh With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire. This change doesn't affect clusters that doesn't have any license set. Release note (ui change): show alert message in Db Console when license is expired or close to expire. Depends on: #120475 Resolves: #98589 Epic: None Screens: 1. Less than 15 days before license expires <img width="1215" alt="Screenshot 2024-03-14 at 13 26 18" src="https://github.com/cockroachdb/cockroach/assets/3106437/54f18792-d16f-43d1-a439-bd04e7a91abd"> 2. License expired <img width="1215" alt="Screenshot 2024-03-14 at 13 25 26" src="https://github.com/cockroachdb/cockroach/assets/3106437/ec9b924a-7800-4cf9-a164-9f4f5b49e91f"> 3. License expired today <img width="1215" alt="Screenshot 2024-03-14 at 13 25 59" src="https://github.com/cockroachdb/cockroach/assets/3106437/38a29b0d-47c3-447a-beb5-d557b58bcfc9"> 120505: sql: deflake TestTrackOnlyUserOpenTransactionsAndActiveStatements r=rafiss a=rafiss This changes the test to block in AfterExecute rather than OnTxnFinish, which should make the active statements assertion less flaky. It also fixes a testing bug where the SELECT FOR UPDATE was not in a txn. fixes #120042 fixes #120235 fixes #119829 Release note: None 120547: ccl/cliccl: avoid opening Engine in debug encryption-decrypt r=sumeerbhola a=jbowens Adapt the `debug encryption-decrypt` command to avoid actually opening the Engine and instead only open the filesystem environment. This allows the command to be used even when missing or corrupt files prevent the Engine from being opened. Epic: none Fix #96699. Release note: none 120562: build: update `rules_go` r=jlinder a=rickystewart ... to pull in `0e7e4e31aa49f1afbb402fbb4895f38bc702c88c`. See bazelbuild/rules_go#3890 This reverts a change in bazelbuild/rules_go#3824 which makes it much more difficult to see build errors. Epic: none Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends response for
uiconfigendpoint which now contains information about license type and time until license expires.Related: #98589
Release note: None
Epic: None