sql: fix statement generation when ensuring roles #135634
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we started skipping over non-existent roles in 35f723e, we need to make sure we only add commas at the appropriate point. The test update demonstrates that there was a bug before this patch, as it would fail with: ``` expected: ok defaultdb found: ERROR: LDAP authorization: error assigning roles to user ldap_user: EnsureUserOnlyBelongsToRoles-grant: at or near ",": syntax error (SQLSTATE 42601) HINT: try \h GRANT DETAIL: source SQL: GRANT , "ldap-parent-synced" TO ldap_user ``` Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started skipping over non-existent roles in 35f723e, we need to make sure we only add commas at the appropriate point.
The test update demonstrates that there was a bug before this patch, as it would fail with:
informs #133779
Release note: None