Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix statement generation when ensuring roles #135634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sql: fix statement generation when ensuring roles #135634

wants to merge 1 commit into from
+9 −5

Commits on Nov 18, 2024

  1. sql: fix statement generation when ensuring roles 

    Since we started skipping over non-existent roles in
35f723e, we need to make sure we only
add commas at the appropriate point.

The test update demonstrates that there was a bug before this patch, as
it would fail with:
```
expected:
ok defaultdb

found:
ERROR: LDAP authorization: error assigning roles to user ldap_user: EnsureUserOnlyBelongsToRoles-grant: at or near ",": syntax error (SQLSTATE 42601)
HINT: try \h GRANT
DETAIL: source SQL:
GRANT , "ldap-parent-synced" TO ldap_user
```

Release note: None
    @rafiss
    rafiss committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    55a138f View commit details
    Browse the repository at this point in the history