jobs: hang the job registry off the server context #72605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, log messages related to jobs were disconnected from the server context and were thus missing the node ID and other log tags. This patch fixes it. Release note: None
|
This change is |
|
TFYR! bors r=miretskiy |
|
Build succeeded: |
This was referenced Nov 11, 2021
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2021
72471: kvserver: fix bugs in & fortify tenant refcounting r=ajwerner a=tbg This PR fixes a sandwich of two bugs around refcounting the tenant rate limiters and metrics that I found while prototyping around #72374. We had an accidental early return in `postDestroyRaftMuLocked` that meant that tenant metrics and rate limiters were essentially never released. We were also continuing to use at least the tenant metrics object after the call to `postDestroyRaftMuLocked` had returned (but note that the above bug meant that we hadn't actually released the ref). This PR fixes both and adds precautions against regressions of such bugs. Despite having fixed bugs, I would be cautious about backporting this to 21.2 and 21.1; the bugs here never seem to have caused any problems, and since our day-to-day testing isn't heavy on tenants, it's unclear how reliably we'd be shaking out problems that were previously masked by the bug. 72836: server,sql,kv: various context improvements r=miretskiy,tbg a=knz Informs #58938. Connects more async goroutines to the tracer. Also fixes various defects I introduced in #72638 and #72605. Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Tobias Grieger <tobias.schottdorf@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #58938.
Prior to this patch, log messages related to jobs were disconnected
from the server context and were thus missing the node ID and other
log tags.
This patch fixes it.
Release note: None